Bug fixes #1819
Merged
Bug fixes #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # If this is a runsettings file then try to get the custom results location from it | ||
|
|
||
| if((([string]::Compare([io.path]::GetExtension($runSettingsFilePath), ".runsettings", $True) -eq 0) -Or ([string]::Compare([io.path]::GetExtension($runSettingsFilePath), ".tmp", $True) -eq 0)) -And |
There was a problem hiding this comment.
can u simplify this? Refactor the into method like
IsRunSettingsFile
CheckIfNotFolder etc
|
rest looks fine to me |
| if((([string]::Compare([io.path]::GetExtension($runSettingsFilePath), ".runsettings", $True) -eq 0) -Or ([string]::Compare([io.path]::GetExtension($runSettingsFilePath), ".tmp", $True) -eq 0)) -And | ||
| !(Test-Path $runSettingsFilePath -pathtype container)) | ||
| { | ||
| $runSettingsForTestResults = [System.Xml.XmlDocument](Get-Content $runSettingsFilePath) |
There was a problem hiding this comment.
If the node we are looking for is not there, it will default to old behaviour. If the xml structure itself is wrong, it will fail as expected with appropriate error.
|
Approving with suggestions. Please do resolve them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
BUG 592101: Minor help text fix
BUG 594989: Supporting publish from custom results location in runsettings
Validation: Manual , UTs